Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons in feed wizard not working #178

Merged
merged 7 commits into from Jan 2, 2024
Merged

Conversation

ProgramComputer
Copy link

php-dom is required for feed wizard. some buttons did not work.
how_to is not clear whether filter includes or excludes.

set feed_text as empty string

@HugoFara HugoFara added bug Something isn't working ux User Experience could be better labels Jan 1, 2024
Copy link
Owner

@HugoFara HugoFara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were only for the issue explained in the title I would merge the changes immediately, but some elements from another PR are included here so I will need you to remove them first.

Some little bugs are also present (see comments).

Also, why do think php-dom is required? Did you spot any specific bug or issue?

INSTALL.sh Outdated Show resolved Hide resolved
feed_wizard.php Outdated Show resolved Hide resolved
feed_wizard.php Outdated Show resolved Hide resolved
feed_wizard.php Outdated Show resolved Hide resolved
inc/database_connect.php Outdated Show resolved Hide resolved
@ProgramComputer
Copy link
Author

If it were only for the issue explained in the title I would merge the changes immediately, but some elements from another PR are included here so I will need you to remove them first.

Some little bugs are also present (see comments).

Also, why do think php-dom is required? Did you spot any specific bug or issue?

php-dom or php-xml is required on Ubuntu 22.
Screenshot 2024-01-02 075711

Copy link
Owner

@HugoFara HugoFara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the previous issues are fixed, let's merge!

@HugoFara HugoFara merged commit 4694f24 into HugoFara:dev Jan 2, 2024
@ProgramComputer
Copy link
Author

ProgramComputer commented Jan 2, 2024

All the previous issues are fixed, let's merge!

@HugoFara I tried php-dom and php-xml. Either is fine. I checked yum and I think php-xml is available and not php-dom.

HugoFara added a commit that referenced this pull request Jan 3, 2024
New databse migration strategy.
Fixes feeds (#168).
Adds missing documentation to Docker (#146, #160).
Changes in PHP and JS globals.
Fixes reading position was not set.
Read text through API (#153, #155).
Fixes word was not saved/deleted.
Fixes #170 and #69.
Updates API (#175).
Adds dependency to php-xml (#178, #181).
Updates makefile (#179).
Adds MeCab support on Mac (#135).
Adds the option to hide/show word romanization (#119).
Raises URL size limit to 2048 (#144).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux User Experience could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants