Resolves #69 Not a nice bug #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new_expression_interactable2 is called once and declares title again. https://github.com/ProgramComputer/lwt/blob/05afb1b8089e5ad6a60ded87e547a49cebd2d7d4/new_word.php#L76
ProgramComputer
changed the title
ProgramComputer
force-pushed
the
patch-9
branch
from
a722901
to
6981f12
Compare
HugoFara
added a commit
that referenced
this pull request
Jan 1, 2024
HugoFara
added a commit
that referenced
this pull request
Jan 1, 2024
HugoFara
added a commit
that referenced
this pull request
Jan 1, 2024
|
You did not describe the bug, so I'm not sure what is the issue you want to address. At any rate, I implemented the bug fix about the title and the missing data. I let you tell me if you were thinking of anything else. See you! |
HugoFara
added a commit
that referenced
this pull request
Jan 3, 2024
New databse migration strategy. Fixes feeds (#168). Adds missing documentation to Docker (#146, #160). Changes in PHP and JS globals. Fixes reading position was not set. Read text through API (#153, #155). Fixes word was not saved/deleted. Fixes #170 and #69. Updates API (#175). Adds dependency to php-xml (#178, #181). Updates makefile (#179). Adds MeCab support on Mac (#135). Adds the option to hide/show word romanization (#119). Raises URL size limit to 2048 (#144).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new_expression_interactable2 is called once in new_word.php but declares title again.
lwt/new_word.php
Line 76 in 05afb1b