Fix right-frame google translation link. #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Google Translate URL, every "translate click" fails on the first click, which is annoying. This is a very simple fix.
The current pre-PR code uses a series of calls to eventually open a new window with a header Location change. I believe that Google has blocked this for XSS attack reasons. This change just makes the proper URL using plain javascript and then opens the window. It's very clear what's happening with this new code, but I don't know enough project history to say if this is an acceptable change or not.
Note that the 'translate sentence' in the reading pane pop-up is still broken, because it uses a slightly different set of calls, and still relies on the Location header change.
Issuing this PR to master because master is currently broken, so it's a hotfix.