This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Update transitive dependencies, fix vulnerability #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2018-3728 `rm yarn.lock` `yarn install` There is currently no way to update single transitive dependencies see: yarnpkg/rfcs#54
The dependency manager of this repository is `yarn` not `npm`, so we should only keep `yarn.lock` but not `package-lock.json` in order not to confuse vulnerability scans of Github.
|
We have to check if the new versions still are working. Also the build is failing currently. |
|
As this breaks the build for not known reason, we still wait for a proper resolution on this. |
appinteractive
added
Help-Wanted
|
Fixed with #63 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2018-3728
rm yarn.lockyarn installThere is currently no way to update single transitive dependencies
see: yarnpkg/rfcs#54