Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment for single end SS2 #123

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

mckinsel
Copy link

No description provided.

@pullapprove pullapprove bot requested review from hjfbynara and tbl3rd May 14, 2019 20:27
@@ -132,6 +132,13 @@ docker run -i --rm \
-e TENX_WDL_LINK="${TENX_WDL_LINK}" \
-e TENX_WORKFLOW_NAME="${TENX_WORKFLOW_NAME}" \
-e TENX_VERSION="${TENX_VERSION}" \
-e SS2_SE_ANALYSIS_WDLS="${SS2_SE_ANALYSIS_WDLS}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more place that needs updating is the template for Lira's config file, otherwise this command to render the template will throw an error since these variables are not currently required in the template: https://github.com/HumanCellAtlas/secondary-analysis-deploy/blob/dev/config_files/lira-config.json.ctmpl#L32

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, sorry forgot to check that in.

Copy link
Member

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the comment Saman left!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants