Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-4864: LEAP-148: Magic Wand doesn't work with MIG #175

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nicholasrq
Copy link
Member

@nicholasrq nicholasrq commented Apr 24, 2023

Description

Support asynchronous LSF serialization, it's used for Magic Wand serialization, based on dataURL.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

LSDV-4864

What does this fix?

Fixes inability to use the Magic Wand when image preloading is enabled. It uses async serialization, so all lsf-sdk methods should be ready for this.

What is the new behavior?

Magic Wand works with image preloading enabled

What is the current behavior?

Magic Wand doesn't work when the image preloading is enabled

What libraries were added/updated?

None

Does this change affect performance?

No

Does this change affect security?

No

What alternative approaches were there?

None

What feature flags were used to cover this change?

fflag_feat_front_dev_4081_magic_wand_tool
fflag_feat_front_lsdv_4583_6_images_preloading_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Labeling Interface, Image Segmentation, Magic Wand

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one small change.

src/stores/DataStores/tasks.js Show resolved Hide resolved
@nicholasrq nicholasrq changed the title fix: LSDV-4864: Magic Wand doesn't work with MIG fix: LSDV-4864: LEAP-148: Magic Wand doesn't work with MIG Jan 11, 2024
src/sdk/lsf-sdk.js Outdated Show resolved Hide resolved
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a minor lint error, other wise approved

Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants