Fix bug with checking only the last required group

examples/required/completions/1.json

@@ -0,0 +1,13 @@
+{
+    "completions": [
+        {
+            "id": "1001",
+            "result": []
+        }
+    ],
+    "data": {
+        "text": "To have faith is to trust yourself to the water"
+    },
+    "id": 1,
+    "task_path": "../examples/references/tasks.json"
+}

examples/required/config.xml

@@ -0,0 +1,11 @@
+<View>
+  <Text name="text" value="$text"></Text>
+  <Choices name="validation-label" required="true" toName="text">
+    <Choice value="Missing words" alias="missing-words"></Choice>
+    <Choice value="Valid" alias="valid"></Choice>
+  </Choices>
+  <Choices name="second" required="true" toName="text">
+    <Choice value="Don't select me" alias="dont"></Choice>
+    <Choice value="Me neither" alias="neither"></Choice>
+  </Choices>
+</View>

examples/required/index.js

@@ -0,0 +1,5 @@
+import config from "./config.xml";
+import tasks from "./tasks.json";
+import completion from "./completions/1.json";
+
+export const Required = { config, tasks, completion };

examples/required/tasks.json

@@ -0,0 +1,31 @@
+[
+    {
+        "data": {
+            "text": "To have faith is to trust yourself to the water"
+        },
+        "predictions": [
+            {
+                "model_version": "model 1",
+                "created_ago": "3 hours",
+                "result": [
+                    {
+                        "from_name": "validation-label",
+                        "id": "NT0HCnJjv5",
+                        "to_name": "text",
+                        "type": "choices",
+                        "value": {
+                            "choices": [
+                                "valid"
+                            ]
+                        }
+                    }
+                ]
+            }
+        ]
+    },
+    {
+        "data": {
+            "text": "When you swim you don't grab hold of the water, because if you do you will sink and drown. Instead you relax, and float."
+        }
+    }
+]

src/core/Tree.js

@@ -5,6 +5,9 @@ import xml2js from "xml2js";
 import Registry from "./Registry";
 import { guidGenerator } from "./Helpers";
 
+export const TRAVERSE_SKIP = "skip";
+export const TRAVERSE_STOP = "stop";
+
 /**
  * Clone React Tree
  * @param {*} items
@@ -327,10 +330,14 @@ function traverseTree(root, cb) {
 
   visitNode = function(node) {
     const res = cb(node);
-    if (res === "break") return;
+    if (res === TRAVERSE_SKIP) return;
+    if (res === TRAVERSE_STOP) return TRAVERSE_STOP;
 
     if (node.children) {
-      node.children.forEach(chld => visitNode(chld));
+      for (let chld of node.children) {
+        const visit = visitNode(chld);
+        if (visit === TRAVERSE_STOP) return TRAVERSE_STOP;
+      }
     }
   };
 

src/env/development.js

@@ -7,6 +7,7 @@ import Messages from "../utils/messages";
 import { DialogueAnalysis } from "../examples/dialogue_analysis"; // eslint-disable-line no-unused-vars
 import { NamedEntity } from "../examples/named_entity"; // eslint-disable-line no-unused-vars
 import { References } from "../examples/references"; // eslint-disable-line no-unused-vars
+import { Required } from "../examples/required"; // eslint-disable-line no-unused-vars
 import { Sentiment } from "../examples/sentiment_analysis"; // eslint-disable-line no-unused-vars
 import { Nested } from "../examples/nested_choices"; // eslint-disable-line no-unused-vars
 
@@ -42,7 +43,7 @@ import { Pairwise } from "../examples/pairwise"; // eslint-disable-line no-unuse
  */
 // import { AllTypes } from "../examples/all_types"; // eslint-disable-line no-unused-vars
 
-const data = HTMLDocument;
+const data = Required;
 
 /**
  * Get current config

src/stores/CompletionStore.js

@@ -7,7 +7,7 @@ import RegionStore from "./RegionStore";
 import Registry from "../core/Registry";
 import RelationStore from "./RelationStore";
 import TimeTraveller from "../core/TimeTraveller";
-import Tree from "../core/Tree";
+import Tree, { TRAVERSE_STOP } from "../core/Tree";
 import Types from "../core/Types";
 import Utils from "../utils";
 import { AllRegionsType } from "../regions";
@@ -177,7 +177,7 @@ const Completion = types
           ok = node.validate();
           if (ok === false) {
             ok = false;
-            return "break";
+            return TRAVERSE_STOP;
           }
         }
       });

src/stores/RelationStore.js

@@ -3,6 +3,7 @@ import { types, destroy, getParentOfType, getRoot } from "mobx-state-tree";
 import { cloneNode } from "../core/Helpers";
 import { AllRegionsType } from "../regions";
 import { RelationsModel } from "../tags/control/Relations";
+import { TRAVERSE_SKIP } from "../core/Tree";
 
 /**
  * Relation between two different nodes
@@ -38,7 +39,7 @@ const Relation = types
       c.traverseTree(function(node) {
         if (node.type === "relations") {
           relations = node;
-          return "break";
+          return TRAVERSE_SKIP;
         }
       });