Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1061: Start Training should send START_TRAINING event as webhook instead of PROJECT_UPDATE #5761

Merged
merged 16 commits into from
Apr 29, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Apr 20, 2024

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Start Training button on Model settings page sends PROJECT_UPDATE event and it's not possible to distinguish when Start Training really was called.

What does this fix?

ML backend model method fit(..., event, ...) will be able to distinguish the right training event.

What is the current behavior?

ML backend model method fit(..., event, ...) receives PROJECT_UPDATE as event and this can be triggered on any project change event.

@github-actions github-actions bot added the fix label Apr 20, 2024
Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit e532c95
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6629c3669fc1550008043dca

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit e532c95
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6629c3667f92bb000828f369

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.92%. Comparing base (9f1cba7) to head (e532c95).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5761   +/-   ##
========================================
  Coverage    75.92%   75.92%           
========================================
  Files          158      158           
  Lines        13356    13356           
========================================
  Hits         10140    10140           
  Misses        3216     3216           
Flag Coverage Δ
pytests 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq merged commit 77eed02 into develop Apr 29, 2024
37 checks passed
@makseq makseq deleted the fb-DIA-1061 branch April 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants