Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spanish ToWords Translation #151

Closed
wants to merge 3 commits into from

Conversation

thunsaker
Copy link
Contributor

I see that you have a WIP #149 modifying the way ToWords works. If you'd like for me update this PR once those changes are finalized I'd be more than happy to update my code.

This was referenced Apr 10, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks a lot for writing this and even more so for acknowledging the need for an update based on #149. That's already merged in and cleans up things fairly well. So I'd appreciate if you could please update your work. Please rebase and force push up. We really prefer clean flat commit tree.

[InlineData(1999, "mil novecientos noventa y nueve")]
[InlineData(2014, "dos mil catorce")]
[InlineData(2048, "dos mil cuarenta y ocho")]
[Theory]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move Theory to the top.

@thunsaker thunsaker mentioned this pull request Apr 10, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

@bangoker thanks. You can pull this code down on your local repo, add your commits and suggestions on top and push a new PR on your fork and we can take it from there. Or @thunsaker could give you access to his fork so you can directly work on that together! Just throwing it out there.

@thunsaker
Copy link
Contributor Author

@bangoker thanks for the review, I'll make appropriate edits when I get a chance to pull in the latest code.

@thunsaker
Copy link
Contributor Author

@MehdiK changes should be good to go now. I have rebased and forced merged as requested.

I have translated and prepared the code for ToOrdinalWords on a separate branch, since it seems that it was not ready at this time. My implementation of the INumberToWordsConverter is throwing the default NotImplementedException().

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thanks a lot for the contribution. It's merged now. I made a few minor changes. Please review.

@MehdiK MehdiK closed this Apr 11, 2014
@thunsaker thunsaker deleted the es-ToWords branch April 11, 2014 15:59
@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thanks for the contribution. This is now available on NuGet in v1.20.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants