Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision-based DateTimeHumanize (2nd shot) #165

Closed
wants to merge 5 commits into from
Closed

Precision-based DateTimeHumanize (2nd shot) #165

wants to merge 5 commits into from

Conversation

wahidshalaly
Copy link
Contributor

Fixes #101

@wahidshalaly
Copy link
Contributor Author

HOLD ON THIS! There's a mistake I need to fix it first & then push again.

This was referenced Apr 10, 2014
Closed
Closed
@wahidshalaly
Copy link
Contributor Author

I think it's Okay. I thought that something missing but it seems not.

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

I made a few changes on top of this and merged: it was a few commits behind and had to be rebased, there were a few failing Romanian tests. I also renamed a few classes and folders. Please review.

Thanks a lot for this. This is a great addition

@MehdiK MehdiK closed this Apr 10, 2014
@MehdiK MehdiK mentioned this pull request Apr 10, 2014
Closed
@wahidshalaly
Copy link
Contributor Author

Great news :) Thanks for accepting this contribution, it was really interesting time for me.

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thanks for the contribution. This is now available on NuGet in v1.20.2.

@MehdiK MehdiK mentioned this pull request Apr 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add precision to DateTime.Humanize
2 participants
@wahidshalaly @MehdiK