Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeutralResourcesLanguage resolves #75 in Windows Store apps #81

Merged
merged 1 commit into from
Feb 12, 2014
Merged

NeutralResourcesLanguage resolves #75 in Windows Store apps #81

merged 1 commit into from
Feb 12, 2014

Conversation

nigel-sampson
Copy link
Contributor

Adding NeutralResourcesLanguage resolves the problem not getting empty strings from System.Resources.ResourceManager in Windows Store apps.

I've tested this with a sample Windows Store app but haven't included a full on test project for this one test.

@MehdiK
Copy link
Member

MehdiK commented Feb 12, 2014

Thanks.

I tried this a few days ago and it always returned the English resources back. Admittedly I am pretty dumb with Windows Store Apps & may have missed something! Do you know if this works for other languages too?

MehdiK added a commit that referenced this pull request Feb 12, 2014
NeutralResourcesLanguage resolves #75 in Windows Store apps
@MehdiK MehdiK merged commit 72abd8f into Humanizr:master Feb 12, 2014
@nigel-sampson
Copy link
Contributor Author

Just tested this and it works correctly with other languages as well. It doesn't work off just the language of the OS but also the supported languages of the app. So if your app doesn't support say French then it won't use the French resources in Humanizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants