-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing case sensitive type names #75
Comments
did you try then all the data properties will get the attribute that ensures exactly same names as the schema has. |
We did, but the fields don't use the type name as name. I'll give an example. We need to use a PersonIDInput type. This will generate a PersonIdInput class.
We can use 3 methods to pass the argument:
In both case 1 and 2, you need to add the type name to the query. This case sensitive name is not available in de generated classes. We could opt to always use case 3 because it doesn't require a type name, but we think that is not a good practice. |
Aha, I misunderstood, thought that it's about the property names, not type names. I'll add generation of a constant to every input object class. Then next potential next step it could be automatically generate the type name when query parameter created with the type so there is no need to pass it manually. |
Thank you for your quick reaction. That last part is indeed the preferred way. |
added Also added |
Input type names are sometimes needed when you use variables declared inside the query. Does the generator have an option to return the case sensitive schema name of a type without the Pascal casing? We rather use nameof() or something similar, and not a magic string.
The text was updated successfully, but these errors were encountered: