Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

[bug][feature]Font-Awesome fixed and IE9 removed #52

Merged
merged 1 commit into from
Feb 8, 2018
Merged

[bug][feature]Font-Awesome fixed and IE9 removed #52

merged 1 commit into from
Feb 8, 2018

Conversation

Tealk
Copy link
Contributor

@Tealk Tealk commented Feb 8, 2018

PR Submission:

All PR's welcome, even those without an Issue

  • Have tested this PR and it adds a feature or fixes an issue noted below.

Additional Information Below

* replaced the font-awesome js with css
* fixed #47
* fixed #46
* removed IE9 support
@Tealk Tealk changed the title Font-Awesome fixed and IE9 removed [bug][feature]Font-Awesome fixed and IE9 removed Feb 8, 2018
@Hutchy68 Hutchy68 merged commit db642cb into Hutchy68:develop Feb 8, 2018
@Hutchy68
Copy link
Owner

Hutchy68 commented Feb 8, 2018

Merged into develop, thanks!

@Hutchy68 Hutchy68 mentioned this pull request Feb 8, 2018
@kmeyn
Copy link

kmeyn commented Feb 28, 2018

Hi

I did the updates but i still cannot get fontawesome to work unfortunately. It appears it is when swapping out the skin.json lines it breaks but of course that might be related to something else entirely.

@Tealk
Copy link
Contributor Author

Tealk commented Feb 28, 2018

@knutmeyn
If you want, I can take a look at it.

@kmeyn
Copy link

kmeyn commented Feb 28, 2018

Thanks Tealk, I'd appreciate that but the server is behind a firewall still.
Could the issue somehow be related to the server setup?

The impression is that, when/if doing changes stepwise, the fontawesome files still does not appear to be loaded. But that's just my 2cents :)

@Tealk
Copy link
Contributor Author

Tealk commented Feb 28, 2018

it's very hard to say anything about when you can't see it
I'd have to take a look at it with the deverlopment tool

@Hutchy68
Copy link
Owner

Some might be my fault, I just updated the README.md. How are you installing the develop branch version? Since this PR is merged, let's take this conversation back to #47 or #53

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants