Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM + Cross-env #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

PNPM + Cross-env #8

wants to merge 4 commits into from

Conversation

koxx12-dev
Copy link

@koxx12-dev koxx12-dev commented Jun 20, 2023

Hello i replaced npm with pnpm which is a objectively a superior package manager both in speed/performance and space usage (might as well also throw this in), also replaced that hacky env platform specific thing with cross-env, also updated some dependencies (npm was using the same versions as here but from lockfile instead of packages.json)

Signed-off-by: koxx12-dev <80456351+koxx12-dev@users.noreply.github.com>
Signed-off-by: koxx12-dev <80456351+koxx12-dev@users.noreply.github.com>
@TBHGodPro
Copy link
Member

  1. you can't just update libraries how you like, some libraries updates' can mess up the whole proxy, especially when you update core libraries for the proxy
  2. if users do not have pnpm installed, they would have to install it to use the proxy, which adds another step to the whole process

@koxx12-dev
Copy link
Author

koxx12-dev commented Jun 20, 2023

  1. I technically didnt update libraries, i just updated package.json, these versions where already used as npm it got them directly from package-lock.json instead of package.json
  2. ok that indeed does make sense, i didnt think about a typical hypixel player

@Naibuu
Copy link

Naibuu commented Jul 17, 2023

  1. balls
  2. balls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants