Skip to content

Conversation

dpollard-gva
Copy link

The repo doesn't build if we are including it as a dependency to another project VIA npm. This pull request aims to fix that.

adding in scripts to support a node installation rather than a yarn one
Instructions on how to install the repo with NPM
@coveralls
Copy link

Coverage Status

Coverage decreased (-17.6%) to 75.676% when pulling b76abe1 on dpollard-gva:master into 6c1607b on HyperCubeProject:master.

@dpollard-gva
Copy link
Author

FFFF....okay, let me fix coveralls now -_-

@balthazar
Copy link
Owner

You must be doing something wrong, just tried a fresh repo using npm without any issue.

$> cat package.json
{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "dependencies": {
    "binance-api-node": "^0.4.3"
  }
}

$> cat index.js
const Binance = require("binance-api-node").default
const client = Binance()
client.time().then(time => console.log("Binance server time", time))

$> node index.js
Binance server time 1515102485209

@balthazar
Copy link
Owner

Don't worry about the drop of the coverage, it's expected since Travis doesn't expose my secret variable to untrusted PRs

@dpollard-gva
Copy link
Author

Ahhh okay, I wasn't aware there was an NPM package. I was including the base Github repo and the project wouldn't build unless I had these edits in the package.json

@balthazar
Copy link
Owner

🙂 Of course there is, otherwise it would be pretty difficult to use

Thanks for the PR though

@balthazar balthazar closed this Jan 4, 2018
@dpollard-gva
Copy link
Author

No problem, thanks for keeping the repo up! Maybe an annotation should be added to the readme to let others know there's an NPM package they can use?

@balthazar
Copy link
Owner

The installation instruction makes it pretty clear the package is available I believe, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants