Add types for accountInfo, order, prices & time #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR with an initial definition for the methods
accountInfo
,order
,prices
&time
to kick-off TypeScript support. To make sure that the definitions are correct, I checked original payload responses as well as the official Rest API for Binance (2017-12-01).To be consistent with other Binance APIs, I synchronized the naming of the defined types with Binance's Java API:
The only thing were I have been unsure are the parameters used for
price
,stopPrice
andicebergQty
. The documentation here says that these are numbers (https://github.com/HyperCubeProject/binance-api-node#authenticated-rest-endpoints) but all other clients treat them as strings. I also guess these should be strings?Here is an example on how this library can now be used with TypeScript:
Best from Berlin,
Benny