Skip to content

Conversation

maxinminax
Copy link
Contributor

#68

@coveralls
Copy link

Coverage Status

Coverage decreased (-27.6%) to 65.134% when pulling b7a4475 on maxinminax:master into cb058cd on HyperCubeProject:master.

@balthazar
Copy link
Owner

Are you sure changing null to undefined would fix the issue? null is actually what's specified in their README. Would an empty array work? I think it would make more sense

@balthazar balthazar added the bug label Apr 4, 2018
@balthazar
Copy link
Owner

@bennyn Any thoughts on that?

@bennycode
Copy link
Contributor

I am okay with undefined instead of null because that's like it is recommended by the reconnecting-websocket documentation: https://github.com/pladaria/reconnecting-websocket/tree/v3.2.1#max-retries

I also used the undefined value in my initial PR.

@balthazar balthazar merged commit 6247d83 into balthazar:master Apr 4, 2018
@balthazar
Copy link
Owner

Alright thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants