-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sm2sm3testing #18
Sm2sm3testing #18
Conversation
todo: rollback go mod changes for proto related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
依赖目录vendor也提交了,造成很多依赖文件变更,这个目录是否有必要提交?
改动是因为ginko(ut)框架升级而fabric没升级这个框架的依赖。upstream那边我已经提交了相关issue。我们这边确实应该考虑回滚。
|
Sam Yuan
***@***.***
|
Signature is customized by Netease Mail Master
On 01/27/2022 11:36, Xiao Hui wrote:
@xiaohui249 commented on this pull request.
依赖目录vendor也提交了,造成很多依赖文件变更,这个目录是否有必要提交?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
f95443c
to
0951d36
Compare
Signed-off-by: Sam Yuan <yy19902439@126.com>
dcb93c9
to
3042068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
ccssm2 "github.com/Hyperledger-TWGC/ccs-gm/sm2" | ||
"github.com/hyperledger/fabric/bccsp/sm2" | ||
. "github.com/onsi/ginkgo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ginkgo和gomega这两个包是原来fabric自带的么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add some test cases for sm2 package
fix sm3 bug