Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply cancelable context to ALL workers. #167

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Supply cancelable context to ALL workers. #167

merged 7 commits into from
Apr 7, 2021

Conversation

yiwenlong
Copy link
Contributor

@yiwenlong yiwenlong commented Apr 3, 2021 •
edited
Loading

Close #164

@yiwenlong
Modify variable naming spelling errors.
828ffec 
Signed-off-by: yiwenlong <wlong.yi@gmail.com>
@yiwenlong
Supply cancelable context to gRPC clients.
e290685 
Signed-off-by: yiwenlong <wlong.yi@gmail.com>
guoger
guoger requested changes Apr 3, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. conventionally, ctx is passed as first argument in method.
  2. we ought to create one cancellable context from main (or entry), and cascade it all the way to all workers.

@yiwenlong
Copy link
Contributor Author

  1. conventionally, ctx is passed as first argument in method.
  2. we ought to create one cancellable context from main (or entry), and cascade it all the way to all workers.

Got it

@yiwenlong yiwenlong changed the title Supply cancelable context to gRPC clients. Supply cancelable context to ALL workers. Apr 4, 2021
@yiwenlong yiwenlong force-pushed the improve/issue#164 branch 6 times, most recently from 9bac8bf to 4187e45 Compare April 6, 2021 03:06
@yiwenlong
Modify ctx as first argument in method.
6c120a4 
Create one cancellable context from entry.

Signed-off-by: yiwenlong <wlong.yi@gmail.com>
@yiwenlong yiwenlong requested a review from guoger April 6, 2021 06:13
guoger
guoger requested changes Apr 6, 2021
View reviewed changes
pkg/infra/proposer.go Outdated Show resolved Hide resolved
@yiwenlong
Fix Conflicts: pkg/infra/process.go
84463a1 
Signed-off-by: yiwenlong <wlong.yi@gmail.com>
@yiwenlong
Refactor: remove done chane, use ctx.Done() instead.
0658ebd 
Signed-off-by: yiwenlong <wlong.yi@gmail.com>
@yiwenlong yiwenlong requested a review from guoger April 7, 2021 03:22
@guoger guoger merged commit 0d2922a into Hyperledger-TWGC:master Apr 7, 2021
@yiwenlong yiwenlong deleted the improve/issue#164 branch April 7, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoger guoger guoger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create cancellable context.Context and cascade it to all workers
2 participants
@yiwenlong @guoger