Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) #3548

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) #3548

merged 4 commits into from
Sep 8, 2023

Conversation

frjo
Copy link
Contributor

@frjo frjo commented Sep 2, 2023 •
edited

Replaces PR: #3380

@frjo frjo changed the title Add colour to review outcome displays Add colour to review outcome displays and truncate reviewer names Sep 2, 2023
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Status: Needs testing Tickets that need testing/qa Type: Patch Mini change, used in release drafter labels Sep 2, 2023
@frjo frjo requested a review from gmurtaza00 September 3, 2023 14:10
@fourthletter
Copy link
Contributor

Could you please show an example of how names are truncated? Thank you.

@frjo
Copy link
Contributor Author

frjo commented Sep 5, 2023

@fourthletter See e.g. https://test-apply.hypha.app/apply/submissions/23/

@fourthletter
Copy link
Contributor

fourthletter commented Sep 5, 2023 •
edited

I currently do not see the benefit, but would happy to discuss further.

Current

image

New PR (proposed change)

image

@frjo frjo force-pushed the enhancement/review_outcome_displays branch from 8106d2c to e6cd09e Compare September 7, 2023 07:21
@frjo frjo removed the Status: Needs testing Tickets that need testing/qa label Sep 7, 2023
@frjo
Copy link
Contributor Author

frjo commented Sep 7, 2023

@fourthletter

What parts of this was it that you did not want implemented?

  • Colouring of review outcomes
  • Hiding "Avg. Score" if it is zero (0)
  • Truncation of reviewers names
  • Sorting reviews by recommendation.

@frjo frjo force-pushed the enhancement/review_outcome_displays branch from e6cd09e to a65419c Compare September 8, 2023 08:58
@fourthletter
Copy link
Contributor

Great feature!

For Hypha Main - all of these would be helpful for adopters.

  • Colouring of review outcomes
  • Hiding "Avg. Score" if it is zero (0)
  • Truncation of reviewers names
  • Sorting reviews by recommendation.

For OTF, only Colouring of review outcomes. Could we remove "Avg. Score" completely for OTF? Thanks.

@frjo
Copy link
Contributor Author

frjo commented Sep 8, 2023

OTF runs stock Hypha. So what goes in to Hypha is what OTF will use.

ARDC have a custom version of Hypha and are having constant issues with keeping it updated from Hypha stock. I do not want to waist time on that for OTF.

@frjo frjo force-pushed the enhancement/review_outcome_displays branch from a65419c to f46314b Compare September 8, 2023 11:44
@frjo frjo changed the title Add colour to review outcome displays and truncate reviewer names Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) Sep 8, 2023
@frjo
Copy link
Contributor Author

frjo commented Sep 8, 2023

I have removed truncation and sorting from this PR now.

@frjo frjo force-pushed the enhancement/review_outcome_displays branch from 2972fb8 to b6a98cc Compare September 8, 2023 11:52
@frjo frjo merged commit 779f7aa into main Sep 8, 2023
10 checks passed
theskumar added a commit that referenced this pull request Sep 21, 2023
@theskumar
Merge branch 'main' into feature/passwordless-login-signup
6819898 
* main:
  Instruct prettier to ignore Sublime Text files. (#3569)
  Make it possible to control who, none/staff/staff admins, can export submissions (#3561)
  Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) (#3548)
  Add code-style checks to Github CI Actions (#3564)
@fourthletter fourthletter mentioned this pull request Sep 25, 2023
Closed
@theskumar theskumar deleted the enhancement/review_outcome_displays branch February 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theskumar theskumar theskumar approved these changes

@gmurtaza00 gmurtaza00 Awaiting requested review from gmurtaza00

Assignees
No one assigned
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frjo @fourthletter @theskumar