Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code-style checks to Github CI Actions #3564

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add code-style checks to Github CI Actions #3564

merged 2 commits into from
Sep 8, 2023

Conversation

theskumar
Copy link
Member

Easier way to check and fix formatting issues if don't want to go
precommit hooks route

@theskumar theskumar self-assigned this Sep 8, 2023
Easier way to check and fix formatting issues if don't want to go
precommit hooks route
@@ -1,12 +1,17 @@
{% load heroicons %}
<div class="form__item{% if field.help_text %} form__group--wrap{% endif %}{% if field.errors %} form__error{% endif %}{% if not field.initial %} multi-input-field-hidden{% endif %}{% if is_application and field.field.group_number > 1 %} field-group field-group-{{ field.field.group_number }}{% endif %}"{% if is_application and field.field.group_number > 1 %} data-hidden="{% if not show_all_group_fields %}true{% else %}false{% endif %}"{% endif %}" data-multi-field-for="{{ field.field.multi_input_id }}">
<div
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file the indentation has been been mis-behaving b/w of an extra quotes after "endif"

{% endif %}" data-multi-field-for

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broke the <div> attributes into newlines to align things better and also make it readable.

@theskumar theskumar changed the title Add djhtml to 'make fmt' and 'make lint' command Add code-style checks to Github CI Actions Sep 8, 2023
@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Sep 8, 2023
@frjo frjo merged commit e706c47 into main Sep 8, 2023
10 checks passed
@theskumar theskumar deleted the enhancement/makefile branch September 8, 2023 13:14
theskumar added a commit that referenced this pull request Sep 21, 2023
* main:
  Instruct prettier to ignore Sublime Text files. (#3569)
  Make it possible to control who, none/staff/staff admins, can export submissions (#3561)
  Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) (#3548)
  Add code-style checks to Github CI Actions (#3564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants