Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to control who, none/staff/staff admins, can export submissions #3561

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Make it possible to control who, none/staff/staff admins, can export submissions #3561

merged 1 commit into from
Sep 8, 2023

Conversation

frjo
Copy link
Contributor

@frjo frjo commented Sep 7, 2023 •
edited
Loading

Fixes #3560

Adds the settings:

# Should staff be able to export submissions.
SUBMISSIONS_EXPORT_ACCESS_STAFF = env.bool('SUBMISSIONS_EXPORT_ACCESS_STAFF', True)

# Should staff admins be able to export submissions.
SUBMISSIONS_EXPORT_ACCESS_STAFF_ADMIN = env.bool('SUBMISSIONS_EXPORT_ACCESS_STAFF_ADMIN', True)

@frjo frjo force-pushed the enhancement/add_permissions_for_submission_export branch from 3fba646 to 6ad6c1b Compare September 7, 2023 12:36
@frjo frjo requested a review from theskumar September 7, 2023 12:37
@frjo frjo force-pushed the enhancement/add_permissions_for_submission_export branch from 6ad6c1b to 854b2c2 Compare September 7, 2023 13:38
@frjo frjo changed the title Make it possible to allow none/staff/staff admins to export submissions. Make it possible to control who, none/staff/staff admins, can export submissions Sep 7, 2023
theskumar
theskumar approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frjo frjo force-pushed the enhancement/add_permissions_for_submission_export branch from 854b2c2 to 1a0da7b Compare September 8, 2023 09:20
@frjo frjo force-pushed the enhancement/add_permissions_for_submission_export branch from 1a0da7b to 41c7689 Compare September 8, 2023 09:23
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Sep 8, 2023
@frjo frjo merged commit dc68d65 into main Sep 8, 2023
10 checks passed
theskumar added a commit that referenced this pull request Sep 21, 2023
@theskumar
Merge branch 'main' into feature/passwordless-login-signup
6819898 
* main:
  Instruct prettier to ignore Sublime Text files. (#3569)
  Make it possible to control who, none/staff/staff admins, can export submissions (#3561)
  Add colour to review outcome displays and do not show "Avg. Score" if it is zero (0) (#3548)
  Add code-style checks to Github CI Actions (#3564)
@theskumar theskumar deleted the enhancement/add_permissions_for_submission_export branch February 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theskumar theskumar theskumar approved these changes

Assignees
No one assigned
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create permissions for submission export on rounds, allowing none/staff/staff admins to export
2 participants
@frjo @theskumar