feat: add OpenFeature provider, tests and examples #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osbornm
reviewed
Nov 26, 2024
osbornm
requested changes
Nov 27, 2024
chrisllontop
changed the title
osbornm
reviewed
Nov 29, 2024
osbornm
reviewed
Dec 2, 2024
examples/express.ts
Outdated
Comment on lines
44
to
52
| app.get('/feature-flag', async (req, res) => { | ||
| const client = OpenFeature.getClient(); | ||
| const flagDetails = await client.getBooleanDetails('example-feature', false, req.context); | ||
|
|
||
| res.json({ | ||
| featureFlag: 'example-feature', | ||
| value: flagDetails.value, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
this works but we'd want something that's more if the flag is true do this logic and false do this other... perhaps something that prints out a message about version or something
osbornm
approved these changes
Dec 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
# 1.0.0 (2024-12-19) ### Bug Fixes * **hyphenClient:** update horizon server URL to use evaluate endpoint ([c9e2f2d](c9e2f2d)) * **hyphenClient:** update mock horizon URL references to use base URL ([27cb479](27cb479)) * make logger parameter optional in provider functions ([#11](#11)) ([ed1d019](ed1d019)) * Throw error on missing or invalid evaluation ([#10](#10)) ([4e2f24b](4e2f24b)) * typo in CONTRIBUTING.md ([c7a0983](c7a0983)) ### Features * add cache config options and key generation ([#12](#12)) ([1c4fb46](1c4fb46)) * add OpenFeature provider, tests and examples ([#4](#4)) ([73ed122](73ed122)) * add telemetry support ([#15](#15)) ([d1d76d9](d1d76d9))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.