Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pyright on strict mode #3287

Closed
wants to merge 6 commits into from
Closed

Fixes for pyright on strict mode #3287

wants to merge 6 commits into from

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Apr 9, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


@Zac-HD
Copy link
Member

Zac-HD commented Apr 10, 2022

At a high level, we want users to be able to strictly type-check their code which uses Hypothesis, so I'll be happy to accept this PR.

On an implementation level, I'd like to have a regression test to stop us from breaking it accidentally (like we did with --junit-xml 😅). Happy to leave the details of that up to you, since unlike @rsokl I haven't used pyright much.

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Apr 10, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


Will do! Just added tests. Will be keeping this PR in draft mode as I continue working through our company codebase and find things that come up

@brandon-leapyear brandon-leapyear marked this pull request as ready for review April 13, 2022 17:54
@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Apr 13, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


@Zac-HD actually, I think this is sufficient for us for now. I probably won't be able to continue typechecking our company codebase for a bit, so I think this is good enough for now, and I can open up more PRs later.

Specifically, I think it'd be good to merge the new pyright tests in sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants