-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strategy for numpy.random.Generator
#3510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsokl
changed the title
Add strategy for
Add strategy for Nov 19, 2022
numpy.random.Generators
numpy.random.Generator
Just dumping thoughts here:
I realize that this amounts to asking for substantial extra work, sorry! Happy to try to find a workable subset if it's too much. Finally, when you say "partially addressing", what will be left after this PR? It'd be nice to have a checklist, or perhaps close the issue and open a newer and more-specific one 😁 |
Closing this as stale 😥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addressing #3131 (only a year later...), this adds
hypothesis.extra.rand_generators
for generatingnumpy.random.Generator
instances with Hypothesis-controlled seeds. These have specialized reprs that enable reproducibility. This bumps our minimum supported version of NumPy to 1.19.01. 1.19.0 has already dropped out of the NEP 29 support window, so I do not think that this is an unreasonable dependency bump.Once #3509 is merged, I can add
numpy.random.Generator
support forregister_random
(I figured out how to make the compatibility shim work)Footnotes
When
BitGenerator
was added to the NumPy's public API ↩