Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking a look at improving
cover
test times.test_targeting_with_following_empty
takes 3-5 seconds to run -target(len(lst))
is dangerous, as my observation is hypothesis occasionally tries doubling the length of the list, which can quickly get out of hand and cause slow generations when unbounded.I was going to simply improve the runtime. However, I don't think the test (and the related
test_targeting_with_many_empty
) is needed anymore. They were introduced in #2137, back when there was special-case handling for empty vs non-empty examples inOptimiser
. This logic was changed in #2289, and I don't think there's a distinction between empty and non-empty anymore, but please correct me if there is.