Fix PermissionError on inaccessible paths
#3815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
Dec 17, 2023
| @@ -69,7 +69,7 @@ def _db_for_path(path=None): | |||
| stacklevel=3, | |||
| ) | |||
| return InMemoryExampleDatabase() | |||
| if path in (None, ":memory:"): | |||
| if path in (None, ":memory:") or not os.access(path, os.R_OK | os.W_OK | os.X_OK): | |||
There was a problem hiding this comment.
I think this is wrong because the path may not exist yet.
The difficulty is that we don't want to create it before we actually need to write something either, both for performance reasons and to avoid annoying people who have Hypothesis installed but aren't using it.
|
This looks like it would need more back-and-forth with the CI than ideal. I'll focus on some other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #3764
I believe the error previous line suggestion wouldn't be reached since that's only when the path is not set, but correct me if I'm wrong.
Also noticed that some of the other databases can have inaccessible paths as well, or I can't find the checks that this comment is refers to. Added one of these database types into the test, but let me know what the desired behavior on this is