Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #231.
Fixed the issue with a couple of additional changes
Additional changes implemented
Code
andCodeList
now feature__eq__
methods which makes for easier comparisons for tests. For the equality operator ofCode
I explicitly exclude thefile
property as it does not influence functionality.Code.file
is now a named attribute.Open question
There is one case which is currently not covered very nicely which concerns the
create_yaml_from_xlsx
function.Say we have an excel like this:
this will be translated into the following yaml:
The issue is that
Primary Energy (mean)
andShare|Coal
both feature an empty region-aggregation attribute since the column exists in the excel and the values for those two variables areNone
.I don't think that there is a way from distinguishing this unintentional
None
from the intentional one forShare|Coal
unit
.Functionality wise this does not change anything though.
I don't think that there's much we can do here, just wanted to point it out.