Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update units submodule after refactoring to package #360

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Update units submodule after refactoring to package #360

merged 3 commits into from
Apr 7, 2020

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Apr 7, 2020 •
edited
Loading

Description of PR

This PR bumps the units submodule to the latest version, which includes refactoring to a package (thanks @khaeru). The paths for importing definitions.txt and package_data are updated. (But the registry definitions are still loaded from definitions.txt rather than importing the iam-units package.)

@danielhuppmann danielhuppmann mentioned this pull request Apr 7, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.714% when pulling d0e788c on danielhuppmann:submodule/units_refactoring into 1170b00 on IAMconsortium:master.

@danielhuppmann danielhuppmann merged commit 9e7ef4b into IAMconsortium:master Apr 7, 2020
@danielhuppmann danielhuppmann deleted the submodule/units_refactoring branch April 8, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhuppmann @coveralls