Use recommended dictConfig for logging configuration #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
=======================================
- Coverage 95.0% 95.0% -0.1%
=======================================
Files 64 63 -1
Lines 6134 6151 +17
=======================================
+ Hits 5828 5844 +16
- Misses 306 307 +1 ☔ View full report in Codecov by Sentry. |
|
I can't re-run the failing test, but given that the other tests (especially for py3.12) passed, I'd assume that this error is flaky and not related to the changes made in this PR. |
danielhuppmann
approved these changes
Apr 19, 2024
danielhuppmann
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks @glatterf42, hope that this will resolve some downstream issues...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in tandem with iiasa/ixmp4#83, where you can find an extensive description of the underlying issue. For pyam, there is no
server.conf, so these parts can be disregarded.Does this PR need to be mentioned in the release notes?
Also, can we please have a quick patch release after merging this?