Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release version #33

Merged
merged 8 commits into from
Mar 18, 2019
Merged

Prepare release version #33

merged 8 commits into from
Mar 18, 2019

Conversation

philipheinisch
Copy link
Member

Includes small fixes to support all Windows power profiling libraries in a single build.
Attached is a precompiled version including the required HDF5 DLLs for testing before release.

toolkitiCL.zip

@ranocha
Copy link
Member

ranocha commented Mar 18, 2019

I will test the binaries this afternoon/evening.

src/main.cpp Show resolved Hide resolved
@ranocha
Copy link
Member

ranocha commented Mar 18, 2019

I get an error on Windows using the binaries if I select power/temperature logging for Intel:

toolkitICL> .\toolkitICL.exe -intel_power 500 -intel_temp 500 -d 2 -b -c SSPRK_test.h5
Available OpenCL devices: 3
Benchmark mode

GeForce GTX 1070 Ti
OpenCL version: OpenCL 1.2 CUDA
Memory limit: 8589934592
WG limit: 1024

Reading kernel from file: SSPRK_kernel.cl ...
Found Kernels: 4
Number of Kernels to execute: 46608
Ingesting HDF5 config file...
Creating output HDF5 file...
Old HDF5 data file found and deleted!
Setting range...
Using Intel Power Gadget interface...
error: failed to initialize MDH_Context
Sleeping for 4s

Launching kernel...
Kernels executed: 46608
Kernel runtime: 2342 ms

Sleeping for 4s
Saving results...

Nevertheless, the logging seems to be fine.

julia> h5open("out_SSPRK_test.h5", "r") do io
           display(read(io, "/housekeeping/intel"))
       end
Dict{String,Any} with 8 entries:
  "temperature_time"    => [1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.5
  "TDP"                 => 95.0
  "package_temperature" => UInt16[0x0022, 0x0022, 0x0022, 0x0022, 0x0022, 0x0022, 0x0022, 0x0032, 0x0036, 0x0036    0x
  "power_time"          => [1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.55291e9, 1.5
  "DRAM0"               => Float32[0.444122, 0.459119, 0.45039, 0.446602, 0.448259, 0.446364, 0.449206, 0.463428, 0.508
  "Package_power_limit" => 95.0
  "cores0"              => Float32[1.58965, 1.83813, 1.23916, 1.19193, 1.22519, 1.16007, 1.5695, 7.0671, 29.8957, 30.12
  "package0"            => Float32[4.97291, 5.25945, 4.66966, 4.61355, 4.65522, 4.57991, 4.99975, 10.4579, 33.3535, 33.

@ranocha
Copy link
Member

ranocha commented Mar 18, 2019

Apart from the error message error: failed to initialize MDH_Context, everything seems to be fine on both Windows and Linux.

@philipheinisch
Copy link
Member Author

I get the same thing on all systems, which are not the original build system. It seems to me, that somehow the interface gets reinitialized - which fails, but as the library is already loaded, it still works. Do we want to try and fix this prior to release?

@ranocha
Copy link
Member

ranocha commented Mar 18, 2019

Since the error does not seem to be crucial and all functionality is available, we might publish this version now. However, if you think that it is not too difficult or time consuming for you to fix this issue now, that would of course be nice.

src/main.cpp Show resolved Hide resolved
src/rapl.cpp Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
@philipheinisch philipheinisch merged commit 1ab94a4 into IANW-Projects:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants