Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAC and CRS code updates for 21/01/2022 - FIXED #7

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

nosvalds
Copy link
Contributor

@nosvalds nosvalds commented Mar 1, 2022

Trello

  • sync from Non-Embedded Codelists
  • DAC and CRS code updates for 21/01/2022

@amy-silcock @akmiller01 I think the last PR was flawed. I had not updated "IATI_codelists" in this repo from the source of truth. This seems to have produced fewer changes. I also noticed that there is a withdrawal-date in convert_to_iati.py that needed to be updated to the date that OECD made their updates.

@nosvalds nosvalds changed the title updates/2022 01 21 fix DAC and CRS code updates for 21/01/2022 - FIXED Mar 1, 2022
Copy link
Contributor

@akmiller01 akmiller01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

Copy link

@amy-silcock amy-silcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions look much better.

The CRSChannelCode withdrawn codes still need be added in to our codelist version.

They are 50000 and 52000

@nosvalds
Copy link
Contributor Author

nosvalds commented Mar 1, 2022

@amy-silcock the files that will be merged with IATI-Codelist-NonEmbedded are in the DAC_to_IATI/ directory.

50000 and 52000 are still present in that file:

  • <codelist-item status="withdrawn" withdrawal-date="2015-12-31">
    <code>50000</code>
    <name>
    <narrative>Others</narrative>
    <narrative xml:lang="fr">Autres</narrative>
    </name>
    </codelist-item>

  • <codelist-item status="withdrawn" withdrawal-date="2015-12-31">
    <code>52000</code>
    <name>
    <narrative>Other</narrative>
    <narrative xml:lang="fr">Autre</narrative>
    </name>
    <category>50000</category>
    </codelist-item>

@amy-silcock
Copy link

To check, are the DAC_to_IATI/ directory files the ones that appear on the IATI website? We should presenting the codelists which also include the withdrawn codes.

@nosvalds
Copy link
Contributor Author

nosvalds commented Mar 3, 2022

@amy-silcock this is just a staging repo for the DAC/CRS changes. I will copy the files from DAC_to_IATI/ to IATI-Codelists-NonEmbedded. That repo holds the SSOT info for what's on the website. Here is a draft PR of what that will look like:

IATI/IATI-Codelists-NonEmbedded#357

The PR just shows the Diff of what will be changing. If you want to see what's currently there you can look at the file:
https://github.com/IATI/IATI-Codelists-NonEmbedded/blob/master/xml/CRSChannelCode.xml

@nosvalds
Copy link
Contributor Author

@amy-silcock have you had a chance to review this again? Let me know if you'd like to chat quickly to get it straight.

@amy-silcock
Copy link

Thanks for the prompt Nik. Good to see the withdrawn codes will still be showing on our version of the codelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants