-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAC and CRS code updates for 21/01/2022 - FIXED #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions look much better.
The CRSChannelCode withdrawn codes still need be added in to our codelist version.
They are 50000 and 52000
@amy-silcock the files that will be merged with IATI-Codelist-NonEmbedded are in the 50000 and 52000 are still present in that file:
|
To check, are the DAC_to_IATI/ directory files the ones that appear on the IATI website? We should presenting the codelists which also include the withdrawn codes. |
@amy-silcock this is just a staging repo for the DAC/CRS changes. I will copy the files from IATI/IATI-Codelists-NonEmbedded#357 The PR just shows the Diff of what will be changing. If you want to see what's currently there you can look at the file: |
@amy-silcock have you had a chance to review this again? Let me know if you'd like to chat quickly to get it straight. |
Thanks for the prompt Nik. Good to see the withdrawn codes will still be showing on our version of the codelist. |
Trello
@amy-silcock @akmiller01 I think the last PR was flawed. I had not updated "IATI_codelists" in this repo from the source of truth. This seems to have produced fewer changes. I also noticed that there is a
withdrawal-date
inconvert_to_iati.py
that needed to be updated to the date that OECD made their updates.