-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV upload > description #25
Comments
The "description" field is currently not processed on the CSV upload/download. Should it be? |
Looking through http://iatiregistry.org/dataset/new it seems that this (along with tags) are the only fields that are not processed. Description should certainly be so. Just wondered if there might be an unforeseen issue with use of illegal characters / line breaks / formatting though (at the user end more than via the CSV file)? |
The spreadsheet controller now supports a "description" column. This is optional to support the files created in previous versions. If the description field is empty it's assumed that the current value (if any) needs to be deleted. Descriptions have the same unicode checks as titles.
@stevieflow Although adding support for the description field is easy enough I think this needs significant testing to account for things like encodings, new lines, etc. I've deployed a patch for supporting this field to the staging site, would be great if you or others could test this extensively (think old CSV files without the field being there, line breaks, etc). After some testing we can assess if it's worth adding (it's probably all right but just want to double check) |
Thanks Adria - will do some tests |
We did a test with UNDP data which worked successfully: http://iati2.staging.ckanhosted.com/publisher/undp - but that's just with a single paragraph. Would there be an option to put a character limit on? |
After some testing I've merged this into master. I'd rather not have different validations for the descriptions created via the CSV and the form. If we want to add a character limit we would it for both, but I don't think it will be necessary. Multiple paragraphs are supported fine, you just need to define them in the markdown way, they should be separated by two line breaks (an empty line in eg Excel). See eg: |
Can we clarify whether the field for "description" is possible via the CSV upload?
The text was updated successfully, but these errors were encountered: