[#33][#36] Linkify implementation schedule url, and reorder #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://iati2.staging.ckanhosted.com/publisher/about/aai @Bjwebb @iatisupport if you are happy I'll deploy to production |
|
@amercader Looks good. |
|
@Bjwebb Done. Perhaps you want to add an extra check to see if the "Implementation Schedule" value starts with "http" before creating the link |
Closed
|
That would be a good idea, especially since there's a possible XSS attack by inserting javascript. However, it looks like other parts of CKAN don't do this check before creating the link. #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement @iatisupport's suggestions from #36