Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Add resources folder to package distribution #195

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Add resources folder to package distribution #195

merged 2 commits into from
Oct 24, 2017

Conversation

dalepotter
Copy link
Contributor

@dalepotter dalepotter commented Oct 20, 2017

The source distribution package requires that a MANIFEST.in file
is added to the respoitory, to ensure that the resources folder
is shipped with the code.

This change is tested locally using python setup.py sdist, which results in a dist/pyIATI-0.1.0.tar.gz file, which – when uncompressed – contains the folder iati/resources.

The source distribution package requires that a MANIFEST.in file
is added to the respoitory, to ensure that the resources folder
is shipped with the code.
@dalepotter dalepotter requested a review from a team October 20, 2017 15:38
@dalepotter dalepotter added bug This issue identifies and details a bug. complete A PR that is in a state that is ready for review. repo-management Changes relating to management of the repository. resources Relating to handling of resource (not code) files. and removed bug This issue identifies and details a bug. labels Oct 20, 2017
Copy link
Contributor

@hayfield hayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs updating.
Also suggest a version bump to 0.1.1 (to avoid having to do it later)... though it may be better to do this on a separate PR.

@hayfield hayfield added incomplete A PR that is in a state that is not ready for review. and removed complete A PR that is in a state that is ready for review. labels Oct 23, 2017
@dalepotter
Copy link
Contributor Author

I would suggest the version is changed in a separate pull request, since there are also some minor changes to the README that could be undertaken ahead of 0.1.1 too. From there, I would suggest another PR to bump the version number and add changes to the changelog file.

@hayfield hayfield dismissed their stale review October 24, 2017 09:00

Required changes have been made

@hayfield hayfield added complete A PR that is in a state that is ready for review. and removed incomplete A PR that is in a state that is not ready for review. labels Oct 24, 2017
Copy link
Contributor

@allthatilk allthatilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

@hayfield hayfield merged commit 7e7cd36 into dev Oct 24, 2017
@hayfield hayfield deleted the packaging-fixes branch October 24, 2017 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complete A PR that is in a state that is ready for review. repo-management Changes relating to management of the repository. resources Relating to handling of resource (not code) files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants