This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Change Rule's name attribute to property
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a couple of benefits: - it reduces the number of public methods in a class - it allows the fixture class to be used as a base class for other test groups This still leaves RuleSubclassTestBase with 21 public methods, though this is far fewer than before, and leads to more flexibility.
This brings in non-equality changes from 1cce5c7
The value does not need to be writable after instantiation. This change is the simplest modification based on previous implementation. Whether the '_name' attribute is required could be debated. It does, however, lead to less boilderplate being required in subclasses.
If something can be done with one fixture instance rather than a dozen, this is better - fewer tests means faster runs :)
hayfield
added
bug-fixes
allthatilk
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nameof a Rule should not be writable after instantiation.This changes it from an attribute to a property so that this is the case.