This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Rename functions in resources.py
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The all adds verbosity to the name. That the function name is plural already indicates that there will be multiple.
hayfield
added
api
Before this, some functions with a 'get' prefix were collating a series of paths, while others were constructing a single path. Some level of difference could kinda be identified by the plurality of the name. This was not clear. Having a different verb for different actions is clearer.
The usage of these functions is as if they are constants / variables. As such, code that calls these functions is clearer if they are named as such.
The original name was taken from the pkg_resources module. This module does not have clear naming. As such, better names should be provided when the module is wrapped.
Slight fail in renaming functions for #259...
hayfield
added
complete
hayfield
added
incomplete
|
Currently a fail in the renaming of |
A renaming fail happened. This resolves it.
A function was missed in c9a013a This renames that function for the same reason.
hayfield
added
complete
|
Suggest maybe changing Thoughts @dalepotter? |
This improves clarity between activity, org, all and every type of Schema
dalepotter
approved these changes
Nov 29, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames functions as per the proposed changes in #258.
Fixes renaming part of #258