Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Add a Minor versions constant #264

Merged
merged 4 commits into from
Feb 5, 2018

Conversation

hayfield
Copy link
Contributor

This adds a constant to allow explicit specification of Minor versions.

This is partially preemptive of SemVer.
It also adds naming consistency with the equivalent constant for Major versions.

The relevant test has been improved.

There is one for Major versions, so there should also be one for Minor versions. Consistency.
This checks that values:

- use a dot (.) as a decimal separator
- have 2 decimal places
- do not contain leading or trailing whitespace
@hayfield hayfield added api Changes to the pyIATI API. enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). standard-support Relating to how pyIATI supports a major component within the IATI Standard. labels Dec 19, 2017
@hayfield hayfield added complete A PR that is in a state that is ready for review. incomplete A PR that is in a state that is not ready for review. and removed complete A PR that is in a state that is ready for review. labels Dec 19, 2017
This will detect if patch versioning is introduced
@hayfield hayfield added complete A PR that is in a state that is ready for review. and removed incomplete A PR that is in a state that is not ready for review. labels Dec 19, 2017
@hayfield hayfield requested a review from a team December 19, 2017 10:35
Copy link
Contributor

@allthatilk allthatilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hayfield hayfield merged commit 6504e36 into improve-version-parameter Feb 5, 2018
@hayfield hayfield deleted the minor-versions-constant branch February 5, 2018 13:40
@hayfield hayfield added the versions Relating to IATI Version Numbers. label Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Changes to the pyIATI API. complete A PR that is in a state that is ready for review. enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). standard-support Relating to how pyIATI supports a major component within the IATI Standard. versions Relating to IATI Version Numbers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants