Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Add permanent 2.03 support #307

Merged
merged 17 commits into from
Mar 22, 2018

Conversation

hayfield
Copy link
Contributor

@hayfield hayfield commented Mar 20, 2018

Fixes #306

The content of the Standard itself is yet to be added, so the tests are currently failing.
This includes: Schemas, Rulesets, Codelist Mapping, Embedded Codelists, and pre-migration NE-Codelists.
There was a migration of some Codelists from Embedded to NE alongside 2.03. This migration will occur in another commit, and increase the number of Codelists at 2.03
These tests currently fail. They should pass once the Embedded-to-NE-alongside-2.03 migration has ocurred.
This data is made up of the test files from the SSOT that test Schemas there.
https://github.com/IATI/IATI-Schemas/tree/version-2.03/tests
Alongside 2.03, a number of Codelists are being changed from Embedded to Non-Embedded.
This updates files and symlinks to refer to the Non-Embedded Codelists where appropriate.
bd1f34e missed a number of latest_version markers
This was caused due to failing to scroll down through some search results, so missing that there were necessary updates in 'test_version.py' D:
The FlowType Codelist has changed from Embedded to Non-Embedded and had more codes added.
This changes the test to utilise an Embedded Codelist, such that the same functionality is being tested, but less maintenance will be required.
The default Python .gitignore ignores files in folders called 'target'. There is an element in the Standard called 'target', so the test files were being ignored.
This un-ignores these particular files so that the test data is committed.
Some lines had moved into the 0.3.0 section of the changelog that were not present in 0.3.0. This moves them back to unreleased.
@hayfield hayfield added enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). standard-support Relating to how pyIATI supports a major component within the IATI Standard. versions Relating to IATI Version Numbers. labels Mar 20, 2018
This includes both re-adding the line for initial support, as well as noting the re-implementation for long-term support.
@hayfield hayfield added the complete A PR that is in a state that is ready for review. label Mar 20, 2018
@hayfield hayfield requested a review from a team March 22, 2018 10:52
@hayfield hayfield changed the base branch from improve-version-parameter to dev March 22, 2018 10:52
@hayfield hayfield changed the base branch from dev to improve-version-parameter March 22, 2018 10:52
@hayfield hayfield mentioned this pull request Mar 22, 2018
15 tasks
The error is being disabled since the test is checking that failing to provide any arguments causes an error.
Copy link
Contributor

@dalepotter dalepotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README changes regarding NE codelist symlinks are not correct. Symlinks must be to a relative path.

Copy link
Contributor

@dalepotter dalepotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re adding a latest version marker in tests - check if pytest allows for detailed error messages where a specific assertion fails.

Symlinks should be relative rather than absolute so that they are portable across systems.
It was unclear what to do when tests failed due to 'latest_version' marks that had not been updated. This adds a custom error message that guides as to how to resolve the issue.
@hayfield hayfield merged commit 4ef513b into improve-version-parameter Mar 22, 2018
@hayfield hayfield deleted the add-203-more-sustainably branch March 22, 2018 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complete A PR that is in a state that is ready for review. enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). standard-support Relating to how pyIATI supports a major component within the IATI Standard. versions Relating to IATI Version Numbers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants