This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Add permanent 2.03 support #307
Merged
hayfield
merged 17 commits into
improve-version-parameter
from
add-203-more-sustainably
Mar 22, 2018
Merged
Add permanent 2.03 support #307
hayfield
merged 17 commits into
improve-version-parameter
from
add-203-more-sustainably
Mar 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of the Standard itself is yet to be added, so the tests are currently failing.
This includes: Schemas, Rulesets, Codelist Mapping, Embedded Codelists, and pre-migration NE-Codelists. There was a migration of some Codelists from Embedded to NE alongside 2.03. This migration will occur in another commit, and increase the number of Codelists at 2.03
These tests currently fail. They should pass once the Embedded-to-NE-alongside-2.03 migration has ocurred.
This data is made up of the test files from the SSOT that test Schemas there. https://github.com/IATI/IATI-Schemas/tree/version-2.03/tests
Alongside 2.03, a number of Codelists are being changed from Embedded to Non-Embedded. This updates files and symlinks to refer to the Non-Embedded Codelists where appropriate.
bd1f34e missed a number of latest_version markers This was caused due to failing to scroll down through some search results, so missing that there were necessary updates in 'test_version.py' D:
The FlowType Codelist has changed from Embedded to Non-Embedded and had more codes added. This changes the test to utilise an Embedded Codelist, such that the same functionality is being tested, but less maintenance will be required.
The default Python .gitignore ignores files in folders called 'target'. There is an element in the Standard called 'target', so the test files were being ignored. This un-ignores these particular files so that the test data is committed.
… which they exist.
Some lines had moved into the 0.3.0 section of the changelog that were not present in 0.3.0. This moves them back to unreleased.
hayfield
added
enhancement
Some sort of new functionality (rather than fixing or tweaking something that already existed).
standard-support
Relating to how pyIATI supports a major component within the IATI Standard.
versions
Relating to IATI Version Numbers.
labels
Mar 20, 2018
This includes both re-adding the line for initial support, as well as noting the re-implementation for long-term support.
The error is being disabled since the test is checking that failing to provide any arguments causes an error.
dalepotter
reviewed
Mar 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README
changes regarding NE codelist symlinks are not correct. Symlinks must be to a relative path.
dalepotter
reviewed
Mar 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re adding a latest version marker in tests - check if pytest allows for detailed error messages where a specific assertion fails.
Symlinks should be relative rather than absolute so that they are portable across systems.
It was unclear what to do when tests failed due to 'latest_version' marks that had not been updated. This adds a custom error message that guides as to how to resolve the issue.
dalepotter
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
complete
A PR that is in a state that is ready for review.
enhancement
Some sort of new functionality (rather than fixing or tweaking something that already existed).
standard-support
Relating to how pyIATI supports a major component within the IATI Standard.
versions
Relating to IATI Version Numbers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306