This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Remove python 2.7 support #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reasons for removal are detailed in #301 The tests no longer pass when run with Python 2.7. Further work could be undertaken to utilise a greater range of Python 3 features. This commit merely removes attempts to test at 2.7, as well as the shims to enable this.
hayfield
added
code-features
|
I ❤️ python 3. But doesn’t all (?) current IATI python code use python 2? Won’t this change pose a problem for using pyIATI internally? |
|
We've realised that:
(Also I've been questioning Python2 support for a while so this is Hayden's leaving gift to me xD) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons for removal are detailed in #301
The tests no longer pass when run with Python 2.7.
Further work could be undertaken to utilise a greater range of Python 3 features. This commit merely removes attempts to test at 2.7, as well as the shims to enable this.