Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Delete RT on un-RT #23

Closed
IBBoard opened this issue Sep 4, 2019 · 1 comment
Closed

Delete RT on un-RT #23

IBBoard opened this issue Sep 4, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@IBBoard
Copy link
Owner

IBBoard commented Sep 4, 2019

Currently, if you're viewing your timeline and un-RT something then the RT remains.

We should probably send a "Delete" message and make sure that the RT disappears.
@IBBoard IBBoard added the enhancement New feature or request label Sep 6, 2019
IBBoard added a commit that referenced this issue Oct 2, 2019
@IBBoard
Re #23: Expose "inject" for use outside userstream
7b933f7
IBBoard added a commit that referenced this issue Oct 2, 2019
@IBBoard
Re #23: Inject messages on RT/un-RT
d7b94a3 
Needs some improvements

Also tidies up a duplicate "if status" block
IBBoard added a commit that referenced this issue Oct 3, 2019
@IBBoard
Re #23: Keep home and profile in sync
11dd113 
Home timeline shouldn't show own RTs (because Twitter don't include them)

Profile page should support delete
@IBBoard IBBoard mentioned this issue Oct 5, 2019
Closed
IBBoard added a commit that referenced this issue Oct 5, 2019
@IBBoard
Re #23: Only remove if it's for this profile
7d9a23b 
Previously, we were trying to remove tweets from all profiles.
This shouldn't cause problems (because IDs are almost certainly
unique) but it would be wasteful. Better to bail early.
IBBoard added a commit that referenced this issue Oct 5, 2019
@IBBoard
Re #23: Switch to "unretweet" API call
05d9508 
Probably not necessary - destroy works - but it's there so we
should use it properly
@IBBoard
Copy link
Owner Author

IBBoard commented Oct 5, 2019

Seems to work now across Home, Mentions, Profile and Favorites.

@IBBoard IBBoard closed this as completed Oct 5, 2019
IBBoard added a commit that referenced this issue Oct 5, 2019
@IBBoard
Replace bigger PNGs with SVG
89aa9c9 
Suggested in #23. I hadn't realised we weren't shipping the SVG.
128px and above should work okay with the SVG. Below that use PNG.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IBBoard