Check all candidates of module which matches class name. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
fix/custom_module/same-name-class-name
branch
from
2797fc3
to
cbe00fe
Compare
sidepelican
reviewed
Sep 19, 2019
| let moduleCandidates = moduleClasses.lazy.filter({ $0.value.contains(customClass) }).map { $0.key } | ||
| guard !moduleCandidates.isEmpty else { return [] } | ||
| guard let customModule = classableObject.customModule, moduleCandidates.contains(customModule) else { | ||
| let message = "It does not match custom module rule in \(fileNameWithoutExtension). Custom module of \(customClass) is one of \(moduleCandidates)" |
There was a problem hiding this comment.
\(moduleCandidates)this outputs like this
LazyMapSequence<LazyFilterSequence<Dictionary<String, Array<String>>>, String>(_base: Swift.LazyFilterSequence<Swift.Dictionary<Swift.String, Swift.Array<Swift.String>>>(_base: ["ModuleA": ["AView", "BView", "CView",..... (a lot of classes)
I expect module names list.
There was a problem hiding this comment.
I updated the message format.
kateinoigakukun
force-pushed
the
fix/custom_module/same-name-class-name
branch
from
edffe8d
to
e1c6599
Compare
|
LGTM! It works. Thank you! (After this implementation, it found that our project has another misuse of |
|
@sidepelican Aren't you interested to be committer? 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #113