feat: Add color_resources rule #141
Conversation
| private extension AssetsCatalog { | ||
| // namespaced names of the | ||
| var values: [String] { | ||
| return entries.flatMap { $0.values } | ||
| } | ||
| } | ||
|
|
||
| private extension AssetsCatalog.Entry { | ||
| var values: [String] { | ||
| switch self { | ||
| case .group(_, let items): | ||
| return items.flatMap { $0.values } | ||
| case .color(_, let value): | ||
| return [value] | ||
| case .image(_, let value): | ||
| return [value] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
These private extensions are copied from ImageResourceRule.swift.
What do you think about best position of this extensions?
- keep private extensions in each files.
- escalate to internal extension and move to inside of AssetsCatalog.swift
There was a problem hiding this comment.
hmm, xcassets can have same name different assets entry (for example, image and color).
We should filter to only color assets for this rule. (and also filter to image for image_resources rule)
okey, keep private extensions in each files is good.
There was a problem hiding this comment.
okey, fixed for that case. (only for color_resources rule in this PR)
There was a problem hiding this comment.
so there is a bug in https://github.com/IBDecodable/IBLinter/blob/master/Sources/IBLinterKit/Rules/ImageResourcesRule.swift#L90
maybe if the code is moved to AssetsCatalog, rename it to colorNames and imageNames to be clear about the purpose of the accessors
so no more copy paste, or adding new case (like color) , which could create bugs
There was a problem hiding this comment.
Should i fix by moving extension methods to AssetsCatalog.swift and rename to colorNames and imageNames in this PR?
There was a problem hiding this comment.
@phimage I tried to filter by Item enum argument having method instead of xxxNames methods r-plus@df983e6
What do you think of this strategy? (not yet applied for this PR)
There was a problem hiding this comment.
it's more "swifty" and maybe more elegant but
this add just a little runtime cost
so as you want
There was a problem hiding this comment.
I checked how many runtime cost by unit test r-plus@e7d939c
Results in my machine
using enum for filter is about 10% slower than type fixed method. But it is single digit ms level cost in usual size of xcassets. so I want to use swifty way.
is it good?
There was a problem hiding this comment.
okey, picked that commit.
…ith not image type of resource
This rule is for detect missing named colors similar to
image_resourcesrule.