Add networkID param to PVMInstance's DeleteNetwork()

[dharaneeshvrd]

No description provided.

[ismirlia]

So normally we can't change the existing definitions, but in this case it seems that in our code this is unused and from looking at the API, it's currently broken.

@yussufsh thoughts?

What is prompting this change @dharaneeshvrd ?

[dharaneeshvrd]

@ismirlia I have tried using Mac address of the network that I wanted to remove, but getting below 405 error.

failed to delete the network to the pvminstanceid db194b86-6415-480a-8a78-fd3d0b6380f1: [DELETE /pcloud/v1/cloud-instances/{cloud_instance_id}/pvm-instances/{pvm_instance_id}/networks/{network_id}] pcloud.pvminstances.networks.delete (status 405): {}

Tried with this change and it went through, so submitted this fix.

[dharaneeshvrd]

@ismirlia did you get a chance to look at my previous comment?

[dharaneeshvrd]

@Prajyot-Parab @mkumatag Any input here?

[Prajyot-Parab]

/lgtm

[mkumatag]

@dharaneeshvrd are we trying this for first time?

[dharaneeshvrd]

Yes I tried this for the first time and got this error, not sure it ever worked.
The API requires the networkID as required path param https://cloud.ibm.com/apidocs/power-cloud#pcloud-pvminstances-networks-delete.
Not sure how it got missed initially.

[mkumatag]

Yes I tried this for the first time and got this error, not sure it ever worked. The API requires the networkID as required path param https://cloud.ibm.com/apidocs/power-cloud#pcloud-pvminstances-networks-delete. Not sure how it got missed initially.

that's fair.. in that case @ismirlia can we merge this PR?

[ismirlia]

I think it's fine to merge. @yussufsh any thoughts?

[yussufsh]

Network id seems required, as this is a fix for broken api we can merge this.
@ismirlia can you check why the body param with mac is needed? Is it an additional check for deleting the network?