This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Update connections.cc #1021
Merged
Update connections.cc #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to runtime init of version from module init
tgooding
reviewed
Feb 8, 2022
bb/src/connections.cc
Outdated
| boost::property_tree::ptree getVersionPropertyTree(){ | ||
| if (!myV_set){ |
There was a problem hiding this comment.
Is this implicitly under the control of a global mutex? Or is there a threading issue that might show up handling 50-100 simultaneous connections? I'd suggest using a pthread_once() to control initialization (one thread enters, other threads block until 1st thread finishes).
There was a problem hiding this comment.
Pushed up thread once change. Tested with robot regression.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression testing executed via robot.