Allocation Delete failures now save metrics if possible. #34
Conversation
| @@ -117,15 +117,14 @@ bool AllocationAgentUpdateState::HandleNetworkMessage( | |||
| } | |||
|
|
|||
| // If the initialization or reversion was successful reply to the master daemon. | |||
| if ( success ) | |||
| if ( success || response->error_code != CSMI_SUCCESS ) | |||
There was a problem hiding this comment.
if success or not success? Only line i'm confused about. otherwise nothing jumps out as crazy. but I don't know enough about this part of the code to offer any real comment of substance.
explain this to me then I will be ready to approve.
There was a problem hiding this comment.
This section effectively says that if the RevertNode or InitNode returned true (meaning the function completed in a good execution) respond. Additionally, if the response has an error code, meaning the RevertNode executed, but it had problems, we want to respond with the data enriched path.
By having both options in the if statement we capture cases where there's no data enrichment, but a failure was found in one of the functions or before the functions got called (response->error_code defaults to CSMI_SUCCESS). Additionally, we don't skip data enriched payloads just because the function returned an error.
|
Looks like everyone approves. So, I guess you are cleared for pull. |
Candidate fix for Issue #31:
Implemented a new mechanism for handling softer failures in multicast code. Allocation Delete failures will now maintain the metrics after failing.
Added a new field
_ErrorMsgto the multicast properties template class to facilitate this mechanism.