-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multithreaded tests #207
Conversation
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestHmacSHA3_224.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestHmacSHA3_224.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestSHA512_256.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestSHA512_256.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestSHA512_224.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestSHA3_512.java
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/openjceplusfips/multithread/TestDH.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Several updates are made to both FIPS and non-FIPS multithreaded tests. - Base tests are updated to avoid race conditions between class fields - Tests are added and the lists between FIPS and non-FIPS are updated to be similar. - Certain test cases not available in FIPS mode are disabled Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
d0c3cab
to
1cf9cf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, did not see any issue for those multithreaded updated tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Several updates are made to both FIPS and non-FIPS multithreaded tests.
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com