Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multithreaded tests #207

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

KostasTsiounis
Copy link
Member

Several updates are made to both FIPS and non-FIPS multithreaded tests.

  • Base tests are updated to avoid race conditions between class fields
  • Tests are added and the lists between FIPS and non-FIPS are updated to be similar.
  • Certain test cases not available in FIPS mode are disabled

Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com

Copy link
Member

@jasonkatonica jasonkatonica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Several updates are made to both FIPS and non-FIPS multithreaded tests.
- Base tests are updated to avoid race conditions between class fields
- Tests are added and the lists between FIPS and non-FIPS are updated
to be similar.
- Certain test cases not available in FIPS mode are disabled

Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
@IBM IBM deleted a comment from JinhangZhang Sep 30, 2024
Copy link
Collaborator

@taoliult taoliult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not see any issue for those multithreaded updated tests.

Copy link
Collaborator

@JinhangZhang JinhangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants