Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop node 6 and default Prettier configs #131

Merged
merged 14 commits into from
May 5, 2020
Merged

chore: Drop node 6 and default Prettier configs #131

merged 14 commits into from
May 5, 2020

Conversation

quinnturner
Copy link
Member

This PR does two things:

  1. Drop support for Node 6 (introduces spread operator, ES2017 commas, and updates dependencies)
  2. Reformats the project using a Prettier config closer to the default
    • As per their documentation, it's not in their philosophy to introduce extra configuration options for styling (single quotes, commas). Rather than fight their decision, just use their defaults. However, still use LF file ending for consistency across Windows and others OSes.

I do not intend to merge this quickly, as I am open to discussion as to whether dropping Node 6 support is an appropriate step for the project.

Closes: #125

@quinnturner quinnturner mentioned this pull request Apr 1, 2020
Closed
@quinnturner
Update more dependencies
7d8cb12
@quinnturner
Whitelist minimist advisory 1179
ac73dd7 
Unaffected: prototype pollution on a transient devDependency.
@quinnturner
Fix prettier 2.x lints
1b549e0
@quinnturner
Add requirements to README and audit-ci title
b67a140
@quinnturner
Don't lint in Node.js 8
ba32b68 
Prettier 2.x only supports Node.js >= 10.
Production audit-ci still works with Node.js 8.
@quinnturner
endOfLine is defaulted to lf in Prettier 2
479fcdf
@chadxz chadxz mentioned this pull request May 5, 2020
Closed
@chadxz
Copy link

chadxz commented May 5, 2020

this needs merge and upgrade on yargs and mocha to address some security advisories. See #141

@quinnturner quinnturner merged commit 99ae444 into IBM:master May 5, 2020
@quinnturner quinnturner deleted the drop-node-6 branch May 5, 2020 20:47
@quinnturner quinnturner mentioned this pull request May 5, 2020
Closed
quinnturner added a commit to quinnturner/audit-ci that referenced this pull request May 6, 2020
@quinnturner
chore: Release 3.0.0
6a7066e 
- IBM#131 **BREAKING**: Drop node 6 support
- IBM#138 **BREAKING**: Remove deprecated report and summary options
- IBM#131 Change prettier settings
- IBM#139 Use async/await syntax
- IBM#139 Possibly fix IBM#139
- Use npmpublish GitHub Action for releases
@quinnturner quinnturner mentioned this pull request May 6, 2020
Merged
quinnturner added a commit that referenced this pull request May 6, 2020
@quinnturner
chore: Release 3.0.0 (#143)
6ac755c 
- #131 **BREAKING**: Drop node 6 support
- #138 **BREAKING**: Remove deprecated report and summary options
- #131 Change prettier settings
- #139 Use async/await syntax
- #139 Possibly fix #139
- #137 Use npmpublish GitHub Action for releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-patt andy-patt andy-patt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discussion]: Drop support for Node 6
3 participants
@quinnturner @chadxz @andy-patt