Feature: optional --skip-dev flag to exclude devDependencies
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnturner
requested changes
Jun 14, 2021
quinnturner
approved these changes
Jun 14, 2021
|
Awesome! Going to try to release it with this change assuming that it can get resolved quickly: #184 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Both npm and yarn support excluding
devDependenciesfrom auditing.npm
yarn
yarn classic
Proposed Solution
audit-cisupports an optional allowlist where vulnerabilities can be set by advisory id, advisory id & module name, advisory id and module path, or by module name. This PR adds a convenience option to skip all devDependencies by accessing the underlying capability of npm and yarn.By making this an opt-in feature, audit-ci would still be nudging users to include devDependencies in the audit. This differs from the discussion in this closed issue as it would support both npm and yarn and would not require implementing severity levels as it simply acts as a passthrough.