Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent hang when packages reference each other in via #208

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

kyletsang
Copy link
Contributor

Fixes #195

This prevents the infinite loop by visiting another package referenced in via if we have already seen that package when traversing the list.

lib/Model.js Outdated Show resolved Hide resolved
@quinnturner quinnturner self-requested a review October 13, 2021 21:11
Copy link
Member

@quinnturner quinnturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you! Assuming the tests pass, I will merge and release this change shortly.

@quinnturner quinnturner merged commit 9da972a into IBM:main Oct 13, 2021
@kyletsang kyletsang deleted the fix-infinite-loop branch October 13, 2021 21:12
quinnturner added a commit to quinnturner/audit-ci that referenced this pull request Oct 13, 2021
IBM#208 - fix: prevent hang when packages reference each other in `via`
quinnturner added a commit that referenced this pull request Oct 13, 2021
#208 - fix: prevent hang when packages reference each other in `via`
@quinnturner
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit-ci -c --pass-enoaudit takes more than 10 minutes (CI and locally)
2 participants